HDFS storage support via datafusion-objectstore-hdfs #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
github-actions
bot
added
binding/rust
iajoiner
changed the title
|
@yjshen Please check out the integration tests: https://github.com/delta-io/delta-rs/actions/runs/4684975786/jobs/8301645920?pr=1279 There are plenty of |
|
Looks like the errors are really just us not being able to read non-parquet files in Delta when reading Parquet files. So I guess they are ok? |
rtyler
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
From my perspective this looks ready to merge. I would like @wjones127 to click the green button though since he had comments on the original pull request
|
@iajoiner please merge |
|
@rtyler Really thanks! I just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The description of the main changes of your pull request
This is basically the continuation of #1273 (really thanks @yjshen for your contributions! The work is all his..I'm just the guy who tries to get it merged!). I addressed the comments from @wjones127.
Related Issue(s)
Documentation