Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose create_add to the public #1482

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

atefsaw
Copy link
Contributor

@atefsaw atefsaw commented Jun 21, 2023

Description

This PR exposes create_add to the public

Related Issue(s)

Documentation

@github-actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@atefsaw atefsaw changed the title Expose create_add to the public feat: expose create_add to the public Jun 21, 2023
rust/src/writer/mod.rs Outdated Show resolved Hide resolved
rust/src/writer/stats.rs Outdated Show resolved Hide resolved
@roeap
Copy link
Collaborator

roeap commented Jun 22, 2023

Thanks for making the updates @atefsaw!

Right now we are refactoring a lot of things, so I'd like to keep new things we expose to a minimum. Creating an Add action from parquet metadata is something the I agree is useful to others, but maybe we could make the stats module itself again private to the crate, and just re-export create_add at the writer level via.

pub use stats::create_add;

sorry for the extra effort.

@atefsaw
Copy link
Contributor Author

atefsaw commented Jun 26, 2023

Thanks for making the updates @atefsaw!

Right now we are refactoring a lot of things, so I'd like to keep new things we expose to a minimum. Creating an Add action from parquet metadata is something the I agree is useful to others, but maybe we could make the stats module itself again private to the crate, and just re-export create_add at the writer level via.

pub use stats::create_add;

sorry for the extra effort.

Hi @roeap , I've made the changes. can you please review? Thanks!

@wjones127 wjones127 enabled auto-merge (squash) June 28, 2023 19:47
@wjones127 wjones127 merged commit 879c8b1 into delta-io:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing create_add in the API
3 participants