feat: add metadata for deletion vectors #1583
Conversation
aersam
requested review from
wjones127,
fvaleye,
rtyler,
roeap,
houqp,
xianwill and
mosyp
as code owners
github-actions
bot
added
binding/python
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
aersam
changed the title
|
As a next step, one could add the absolute path of the deletion vector to the get_actions method. This requires a dependency on z85 |
|
I'll update the PR in the next days to address the checks |
Should be ok now |
Co-authored-by: Will Jones <willjones127@gmail.com>
That sounds good! I tried making the change in an idiomatic way and I hope I did nothing too bad :) Though I'm new to rust it feels a bit like "Programming done right", but I'm sure I still have to learn a lot there |
|
@aersam Sorry for the delay in re-reviewing. Looks good. Just needs to be rebased and pass CI to merge :) |
No problem, thanks for re-reviewing! I clicked that "Sync" Button :) , should be rebased now |
# Description This just adds the deletion vector metadata to the actions. It does not interpret those yet, reading / writing deletion vectors is not supported with this. Still it enables use cases where you use delta-rs just for metadata retrieval I have to add that I'm still learning rust and I expect this to take some iterations until code quality is sufficient # Related Issue(s) Part of delta-io#1094 : Adds the required metadata # Documentation https://github.com/delta-io/delta/blob/master/PROTOCOL.md#deletion-vectors --------- Co-authored-by: Will Jones <willjones127@gmail.com>
Description
This just adds the deletion vector metadata to the actions. It does not interpret those yet, reading / writing deletion vectors is not supported with this. Still it enables use cases where you use delta-rs just for metadata retrieval
I have to add that I'm still learning rust and I expect this to take some iterations until code quality is sufficient
Related Issue(s)
Part of #1094 : Adds the required metadata
Documentation
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#deletion-vectors