fix: unify environment variables referenced by Databricks docs #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
wjones127
requested changes
Sep 27, 2023
rust/src/data_catalog/unity/mod.rs
Outdated
Comment on lines
172
to
170
| "access_token" | "unity_access_token" | "databricks_access_token" => { | ||
| Ok(UnityCatalogConfigKey::AccessToken) | ||
| } | ||
| "unity_token" | "databricks_token" => Ok(UnityCatalogConfigKey::Token), |
There was a problem hiding this comment.
Hmmm can we leave the old ones in but emit a deprecation warning? Something like:
// TODO: Remove these variables
"access_token" | "unity_access_token" | "databricks_access_token" => {
log::warn!("Environment variable '{}' is deprecated and will be remove in a future veresion. Please use UNITY_TOKEN or DATABRICKS_TOKEN instead.");
Ok(UnityCatalogConfigKey::Token)
}This will just save us some work answering questions about why their environment variables suddenly don't work anymore.
There was a problem hiding this comment.
I don't disagree but don't feel like doing that work today, so I'm going to drop this out of the milestone and release 0.16
rust/src/data_catalog/unity/mod.rs
Outdated
| "workspace_url" | "unity_workspace_url" | "databricks_workspace_url" => { | ||
| Ok(UnityCatalogConfigKey::WorkspaceUrl) | ||
| } | ||
| "unity_host" | "databricks_host" => Ok(UnityCatalogConfigKey::Host), |
There was a problem hiding this comment.
Same thing here, would prefer to provide a deprecation warning first.
rtyler
force-pushed
the
databricks-env-variables-1627
branch
from
4f9d885 to
edd1837
Compare
github-actions
bot
removed
documentation
Long-term fix will be for Databricks to release a Rust SDK for Unity 😄 Fixes delta-io#1627
rtyler
force-pushed
the
databricks-env-variables-1627
branch
from
edd1837 to
13e8be1
Compare
wjones127
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long-term fix will be for Databricks to release a Rust SDK for Unity 😄
Fixes #1627