fix: fail fast for opening non-existent path #1917
Conversation
# Description Save user from ending up with failed `load` function call and new folder created - failing fast in case user is trying to load some path that doesn't exist # Related Issue(s) - closes delta-io#1916
dimonchik-suvorov
requested review from
wjones127,
roeap and
rtyler
as code owners
dimonchik-suvorov
changed the title
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
dimonchik-suvorov
changed the title
dimonchik-suvorov
changed the title
dimonchik-suvorov
changed the title
dimonchik-suvorov
changed the title
| /// is either local path or some kind or URL. | ||
| /// | ||
| /// Will return an error if the path is not valid. | ||
| fn resolve_uri_type(table_uri: impl AsRef<str>) -> DeltaResult<UriType> { |
There was a problem hiding this comment.
basically pulled out from ensure_table_uri to it's own function
…r' into dsuvorov/1916-load-creates-folder
|
@dimonchik-suvorov @rtyler - I see we have a panic in this PR - generally we want to be panic free and let callers handle errors without crashing everything ... could we fix that? |
Sure, will do. It's just my justification was that wrong path it's a pretty wrong to do and I've decided to panic in this case. But sure, I'll rewrite it to return error instead |
Maybe a bit more reasoning behind that :) - assuming someone uses the delta integration in a server and a user provides a erroneous input. In that case a panic would potentially crash the entire server. In that case we would want to allow integrators to forward that error to the user. Since we are a library, I believe that callers should be able to decide if they can recover from such errors. |
Make sense for the library, agree, will fix 🫡 |
This is a continuation of the discussion in the delta-io#1917 Getting rid of panic in the library crate in favor of returning an error so lib users could handle it in a way they see it Test changes accordingly
# Description This is a continuation of the discussion in the #1917 Getting rid of panic in the library crate in favor of returning an error so lib users could handle it in a way they see it Test changes accordingly Co-authored-by: Robert Pack <42610831+roeap@users.noreply.github.com>
# Description This is a continuation of the discussion in the delta-io#1917 Getting rid of panic in the library crate in favor of returning an error so lib users could handle it in a way they see it Test changes accordingly Co-authored-by: Robert Pack <42610831+roeap@users.noreply.github.com>
Description
Save user from ending up with failed
open_tablefunction call and new folder created - failing fast in case user is trying to load some path that doesn't existRelated Issue(s)