Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add alterer #2014

Merged
merged 3 commits into from
Jan 2, 2024
Merged

docs: add alterer #2014

merged 3 commits into from
Jan 2, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Again, forgot some docs, and added missing descriptions

@github-actions github-actions bot added the binding/python Issues for the Python package label Jan 2, 2024
@ion-elgreco ion-elgreco enabled auto-merge (squash) January 2, 2024 16:19
@MrPowers
Copy link
Collaborator

MrPowers commented Jan 2, 2024

@ion-elgreco - how will the end user access this functionality? Like dt.alter....?

@ion-elgreco
Copy link
Collaborator Author

@MrPowers yeah, dt.alter.add_constraint(), and in the future other methods like dt.alter.add_column etc.

@MrPowers
Copy link
Collaborator

MrPowers commented Jan 2, 2024

K, so users won't have to access TableAlterer directly, perfect!

MrPowers
MrPowers approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ion-elgreco ion-elgreco merged commit 4cb754b into delta-io:main Jan 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPowers MrPowers MrPowers approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ion-elgreco @MrPowers