Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor WriterProperties class #2030

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

  • Add better typehint
  • Better description of the compression levels
  • Gracefully handle wrong compression levels, rust parquet errors were not clear enough

@github-actions github-actions bot added the binding/python Issues for the Python package label Jan 4, 2024
@ion-elgreco ion-elgreco changed the title refactor: WriterProperties class feat: refactor WriterProperties class Jan 4, 2024
@delta-io delta-io deleted a comment from github-actions bot Jan 4, 2024
rtyler
rtyler previously approved these changes Jan 4, 2024
roeap
roeap previously approved these changes Jan 4, 2024
python/deltalake/table.py Show resolved Hide resolved
@ion-elgreco ion-elgreco dismissed stale reviews from roeap and rtyler via 8f1fba6 January 4, 2024 10:15
python/tests/test_writerproperties.py Outdated Show resolved Hide resolved
python/deltalake/table.py Outdated Show resolved Hide resolved
@roeap roeap enabled auto-merge (squash) January 4, 2024 10:45
@roeap roeap merged commit 7981b95 into delta-io:main Jan 4, 2024
23 checks passed
r3stl355 pushed a commit to r3stl355/delta-rs that referenced this pull request Jan 10, 2024
# Description
- Add better typehint
- Better description of the compression levels
- Gracefully handle wrong compression levels, rust parquet errors were
not clear enough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants