chore: pin ruff and mypy versions in the lint stage in the CI pipeline
#2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpgmaas
requested review from
wjones127,
rtyler,
fvaleye,
roeap and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
fpgmaas
changed the title
ruff and mypy versions in the lint stage in the CI pipelineruff and mypy versions in the lint stage in the CI pipeline
fpgmaas
changed the title
ruff and mypy versions in the lint stage in the CI pipelineruff and mypy versions in the lint stage in the CI pipeline
fpgmaas
changed the title
ruff and mypy versions in the lint stage in the CI pipelineruff and mypy versions in the lint stage in the CI pipeline
rtyler
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
ruffandmypyhave their latest versions installed in the CI pipeline, while locally they are fixed to a specific version. This can cause issues, see #2678.This PR proposes to fix them to their specific version in the pipeline. The alternative I could think of was installing the virtual environment with
make develop, but that takes between 4 and 5 minutes, which might be considered a bit too long to wait on linting results.This PR will have conflicts with #2674, so I'll need to rebase one of these PR's once the other is merged.
Related Issue(s)
Documentation