Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get earliest version #2797

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

Can be useful if you want to read the earliest version possible.

Related Issue(s)

@ion-elgreco ion-elgreco force-pushed the feat/get_earliest_version branch from acfc636 to 5ed2bb7 Compare August 19, 2024 19:11
@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Aug 19, 2024
@rtyler rtyler force-pushed the feat/get_earliest_version branch from f245081 to 776a4e1 Compare September 9, 2024 14:18
@rtyler rtyler self-assigned this Sep 9, 2024
@rtyler
Copy link
Member

rtyler commented Sep 9, 2024

I will take this over and add the necessary changes. Since this is an update to LogStore some version parameters need to change in Cargo.tomls too.

@rtyler rtyler force-pushed the feat/get_earliest_version branch from 776a4e1 to b63aa2a Compare September 28, 2024 14:07
@rtyler rtyler enabled auto-merge September 28, 2024 14:09
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (72e344e) to head (b63aa2a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/logstore/mod.rs 0.00% 34 Missing ⚠️
python/src/lib.rs 0.00% 7 Missing ⚠️
crates/aws/src/logstore/default_logstore.rs 0.00% 3 Missing ⚠️
crates/aws/src/logstore/dynamodb_logstore.rs 0.00% 3 Missing ⚠️
crates/core/src/logstore/default_logstore.rs 0.00% 3 Missing ⚠️
crates/core/src/table/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
- Coverage   72.47%   72.39%   -0.09%     
==========================================
  Files         131      131              
  Lines       40410    40463      +53     
  Branches    40410    40463      +53     
==========================================
+ Hits        29287    29293       +6     
- Misses       9238     9291      +53     
+ Partials     1885     1879       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler added this pull request to the merge queue Sep 29, 2024
Merged via the queue into delta-io:main with commit 18cc561 Sep 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get minimum available version
2 participants