Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check lowercase config keys with/without aws prefix in s3logstorefactory #2896

Merged
merged 2 commits into from
Sep 23, 2024

feat: disable AWS configuration resolution for non-AWS S3 storage sce…

7055b09
Select commit
Loading
Failed to load commit list.
Merged

fix: check lowercase config keys with/without aws prefix in s3logstorefactory #2896

feat: disable AWS configuration resolution for non-AWS S3 storage sce…
7055b09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 22, 2024 in 0s

72.49% (-0.02%) compared to 68f6d74

View this Pull Request on Codecov

72.49% (-0.02%) compared to 68f6d74

Details

Codecov Report

Attention: Patch coverage is 63.73626% with 33 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (68f6d74) to head (7055b09).

Files with missing lines Patch % Lines
crates/aws/src/lib.rs 5.88% 12 Missing and 4 partials ⚠️
crates/aws/src/storage.rs 75.00% 14 Missing and 2 partials ⚠️
crates/aws/src/logstore/dynamodb_logstore.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
- Coverage   72.50%   72.49%   -0.02%     
==========================================
  Files         131      131              
  Lines       40362    40421      +59     
  Branches    40362    40421      +59     
==========================================
+ Hits        29266    29304      +38     
- Misses       9216     9238      +22     
+ Partials     1880     1879       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov