chore: introduce some more writer tests to demonstrate schema promotion #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests help demonstrate schema evolution behavior when passing timestamps with and without timezones into write_deltalake() which can be confusing sine the `timestampNtz` case causes a necessary but aggressive minWriterVersion upgrade
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
- Coverage 72.43% 72.41% -0.02%
==========================================
Files 131 131
Lines 40545 40545
Branches 40545 40545
==========================================
- Hits 29369 29362 -7
Misses 9293 9293
- Partials 1883 1890 +7 ☔ View full report in Codecov by Sentry. |
rtyler
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
ion-elgreco
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests help demonstrate schema evolution behavior when passing timestamps with and without timezones into write_deltalake() which can be confusing sine the
timestampNtzcase causes a necessary but aggressive minWriterVersion upgrade