-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check top level nullability during write #3026
fix: check top level nullability during write #3026
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3026 +/- ##
==========================================
+ Coverage 72.72% 72.75% +0.03%
==========================================
Files 128 128
Lines 41357 41422 +65
Branches 41357 41422 +65
==========================================
+ Hits 30076 30136 +60
Misses 9338 9338
- Partials 1943 1948 +5 ☔ View full report in Codecov by Sentry. |
be85f80
to
f984855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f984855
to
7c7fef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a good future refactor would be to store a reference to the snapshot in the DeltaDataChecker and then just use that instead of copying the constraints, invariants, etc for doing checks
Description
Adds a check for top level column nullability whether the arrays in recordbatch contain nulls when they shouldn't.
Related Issue(s)
DeltaTable.merge
#2991Notes
This is probably required in nested fields as well, so something for a follow-up