Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check top level nullability during write #3026

Merged

Conversation

ion-elgreco
Copy link
Collaborator

Description

Adds a check for top level column nullability whether the arrays in recordbatch contain nulls when they shouldn't.

Related Issue(s)

Notes

This is probably required in nested fields as well, so something for a follow-up

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (1083c8c) to head (7c7fef7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/mod.rs 93.84% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
+ Coverage   72.72%   72.75%   +0.03%     
==========================================
  Files         128      128              
  Lines       41357    41422      +65     
  Branches    41357    41422      +65     
==========================================
+ Hits        30076    30136      +60     
  Misses       9338     9338              
- Partials     1943     1948       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco force-pushed the fix--check-nullability-in-deltachecker branch from be85f80 to f984855 Compare November 26, 2024 19:09
hntd187
hntd187 previously approved these changes Nov 29, 2024
Copy link
Collaborator

@hntd187 hntd187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ion-elgreco ion-elgreco added this pull request to the merge queue Nov 29, 2024
@rtyler rtyler self-assigned this Nov 29, 2024
@rtyler rtyler removed this pull request from the merge queue due to a manual request Nov 29, 2024
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a good future refactor would be to store a reference to the snapshot in the DeltaDataChecker and then just use that instead of copying the constraints, invariants, etc for doing checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty behavior on nullable columns when using DeltaTable.merge
3 participants