Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fmt scalar view values #3130

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: fmt scalar view values #3130

merged 2 commits into from
Jan 15, 2025

Conversation

ion-elgreco
Copy link
Collaborator

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Jan 14, 2025
@ion-elgreco
fix: fmt scalar view values
5036d5e 
Signed-off-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
@ion-elgreco ion-elgreco force-pushed the fix/fmt_scalar_view_values branch from b600eae to 5036d5e Compare January 14, 2025 20:40
@ion-elgreco ion-elgreco added this to the v0.24 milestone Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.27%. Comparing base (0cfde96) to head (832ebb0).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/expr.rs 16.66% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
- Coverage   72.27%   72.27%   -0.01%     
==========================================
  Files         134      134              
  Lines       42973    42975       +2     
  Branches    42973    42975       +2     
==========================================
  Hits        31059    31059              
+ Misses       9926     9924       -2     
- Partials     1988     1992       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler enabled auto-merge January 15, 2025 02:46
@rtyler rtyler added this pull request to the merge queue Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 03:16

Pull Request is not mergeable

Merged via the queue into delta-io:main with commit 62b108a Jan 15, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtyler rtyler rtyler approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

@hntd187 hntd187 Awaiting requested review from hntd187 hntd187 is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Milestone
v0.24
Development

Successfully merging this pull request may close these issues.

write_delta merge issue: Generic DeltaTable error: Unable to convert expression to string
2 participants
@ion-elgreco @rtyler