feat: add schema evolution to merge statement #3136
+647
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
JustinRush80
force-pushed
the
feat/schema_evo
branch
from
fcc92b2 to
7f1b955
Compare
JustinRush80
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco,
rtyler and
hntd187
as code owners
|
@JustinRush80 can you rebase your branch against main, or allow us to rebase it I will do thorough review tomorrow then :) |
JustinRush80
force-pushed
the
feat/schema_evo
branch
from
6daa9ec to
0a45cf0
Compare
|
@JustinRush80 could you rebase again, something went wrong since files changed is huge |
Signed-off-by: JustinRush80 <69156844+JustinRush80@users.noreply.github.com>
JustinRush80
force-pushed
the
feat/schema_evo
branch
from
0a45cf0 to
53042d8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3136 +/- ##
==========================================
+ Coverage 72.08% 72.27% +0.18%
==========================================
Files 134 134
Lines 43360 43757 +397
Branches 43360 43757 +397
==========================================
+ Hits 31258 31627 +369
- Misses 10085 10094 +9
- Partials 2017 2036 +19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: JustinRush80 <69156844+JustinRush80@users.noreply.github.com>
JustinRush80
commented
Jan 18, 2025
| .unwrap() | ||
| .await | ||
| .unwrap(); | ||
| assert_eq!(metrics.num_target_files_added, 2); |
There was a problem hiding this comment.
@ion-elgreco any ideas why this assert is failing in the Ci pipeline but passing locally?
There was a problem hiding this comment.
Have you tried checking what the output is locally vs in the CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add schema evolution (only merge) to the MERGE statement. New columns are added based on the columns predicates in the MERGE operations (eg. target.id = source.id). Using when_not_matched_insert_all and when_matched_update_all will add any new column to the target schema
Related Issue(s)
Documentation