fix: chrono 0.4.40 causes disambiguation syntax when building arrow deps #3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Falk <alexfalk7@gmail.com>
rtyler
approved these changes
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
+ Coverage 72.08% 72.09% +0.01%
==========================================
Files 143 143
Lines 45530 45530
Branches 45530 45530
==========================================
+ Hits 32820 32825 +5
- Misses 10623 10625 +2
+ Partials 2087 2080 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The crate Chrono has been updated to 0.4.40. This has caused a breaking change in Arrow - as I understand it. This causes Arrow to fail when building due to disambigious syntax. Pinning Chrono to its
=0.4.39release will fix the build issue until the next Arrow release in March.Related Issue(s)
Arrow Issue 7198
Chrono Discussion of the breaking change
Documentation
None