Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Cargo.toml into pyproject.toml #381

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

fvaleye
Copy link
Collaborator

@fvaleye fvaleye commented Aug 12, 2021

Description

Following the latest guidelines from maturin

Documentation

https://github.com/PyO3/maturin/blob/main/Changelog.md#0110---2021-07-04

@fvaleye fvaleye added the binding/python Issues for the Python package label Aug 12, 2021
@fvaleye fvaleye marked this pull request as draft August 12, 2021 09:26
@fvaleye fvaleye force-pushed the python/merge-cargo-into-pyproject branch 2 times, most recently from b3b8f38 to 95d2b13 Compare August 12, 2021 11:49
@fvaleye fvaleye marked this pull request as ready for review August 12, 2021 12:13
@fvaleye fvaleye force-pushed the python/merge-cargo-into-pyproject branch from 95d2b13 to 3357dc5 Compare August 12, 2021 12:17
@fvaleye fvaleye enabled auto-merge (squash) August 12, 2021 12:17
@fvaleye fvaleye merged commit 6dd1cf7 into delta-io:main Aug 12, 2021
@houqp
Copy link
Member

houqp commented Aug 12, 2021

nice, much cleaner than the old cargo definition :)

[project]
name = "deltalake"
requires-python = ">=3.6"
classifier = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be classifiers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @messense , do you want to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants