fix: omit common prefixes in azure list_objs
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @roeap, The vacuum tests panic with the following error message: |
roeap
force-pushed
the
fix-azure-common-prefixes
branch
from
9ff1705
to
0d2ad79
Compare
|
@Blajda - how about now? :) |
roeap
force-pushed
the
fix-azure-common-prefixes
branch
2 times, most recently
from
430faed
to
c0dc9f9
Compare
|
Still fails due to the prefix but it's closer. Just missing the account name |
roeap
force-pushed
the
fix-azure-common-prefixes
branch
from
c0dc9f9
to
e7c616e
Compare
|
One more iteration ... |
|
Yeah that works. Everything passes now expect for |
wjones127
requested changes
Jul 11, 2022
rust/src/storage/azure/mod.rs
Outdated
| modified: p.last_modified, | ||
| size: Some(p.content_length), | ||
| }) | ||
| Ok(paths) => Either::Left(stream::iter(paths.into_iter().flat_map(|p| { |
There was a problem hiding this comment.
Huh I didn't know flat_map worked on Option. Would have guessed to use filter_map usually, and it might be a bit clearer?
Suggested change
| Ok(paths) => Either::Left(stream::iter(paths.into_iter().flat_map(|p| { | |
| Ok(paths) => Either::Left(stream::iter(paths.into_iter().filter_map(|p| { |
wjones127
approved these changes
Jul 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adls gen2 with hierarchical namespaces enabled has a notion of "directories" in an object store, this is in contrast to other object store implementations. This PR brings the behaviour in line with other storage backend implementations in this crate.
leaving this as a draft to see what else needs to be done for azure to be en par with local and s3 in #682.All backend related vacuum tests for azure are passing with this in #682.Related Issue(s)
towards #647
Documentation