[DTS-2474] Introduce Timestamp and UUID as suffix to table path in RemoteDeltaLog #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhou-db
changed the title
chakankardb
reviewed
Dec 1, 2023
| val dateFormat = new SimpleDateFormat("yyyyMMdd_HHmmss") | ||
| dateFormat.setTimeZone(TimeZone.getTimeZone("UTC")) | ||
| val formattedDateTime = dateFormat.format(System.currentTimeMillis()) | ||
| val uuid = UUID.randomUUID().toString().split('-').head |
There was a problem hiding this comment.
Isn't random uuid sufficient?
There was a problem hiding this comment.
uuid is sufficient, I feel datetime is easier for debugging.
| @@ -171,7 +184,8 @@ private[sharing] object RemoteDeltaLog { | |||
| java.lang.Boolean.valueOf(sslTrustAll), | |||
| java.lang.Boolean.valueOf(forStreaming)) | |||
| .asInstanceOf[DeltaSharingClient] | |||
| new RemoteDeltaLog(deltaSharingTable, new Path(path), client) | |||
|
|
|||
| new RemoteDeltaLog(deltaSharingTable, new Path(path + getFormattedTimestampWithUUID), client) | |||
There was a problem hiding this comment.
Do we need a unit test?
There was a problem hiding this comment.
let me see if I can add one. unit test should be just for the suffix, the functionality of e2e query is covered by existing tests.
chakankardb
approved these changes
Dec 1, 2023
zsxwing
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Timestamp and UUID as suffix to table path in RemoteDeltaLog, to avoid two queries on the same table override the CachedTableManager entry for each other.