Adds more logging in DeltaSharingFileSystem #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakankardb
reviewed
Feb 8, 2024
| @@ -154,6 +163,7 @@ private[sharing] class DeltaSharingFileSystem extends FileSystem { | |||
| throw new UnsupportedOperationException("mkdirs") | |||
|
|
|||
| override def getFileStatus(f: Path): FileStatus = { | |||
| logInfo(s"Checking delta sharing file status for path: $f.") | |||
There was a problem hiding this comment.
Question: Is it possible to guard these with some debug level?
There was a problem hiding this comment.
updated to logDebug
chakankardb
approved these changes
Apr 8, 2024
linzhou-db
added a commit
to linzhou-db/delta-sharing
that referenced
this pull request
Apr 8, 2024
* add log * add bufferSize in log * remove uuid from table path * log more * revert to logDebug
This was referenced Apr 8, 2024
linzhou-db
added a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more logging in DeltaSharingFileSystem, to understand # of calls on pre-signed urls.