Fix wheels build by removing duplicate wheels #623
Merged
+5
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJin-db
force-pushed
the
fix-wheels-build
branch
from
9ca0ce1 to
7484665
Compare
chakankardb
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ARM jobs for Linux and Windows were non-functional and created the same wheel as their x86 counterpart. When the final merge job runs, the existence of two identical wheel files caused the wheel in the merged zip file to potentially get corrupted. This PR fixes that issue by removing the ARM jobs for Linux and Windows.
To verify that the wheels are fixed, I re-ran the merge action 10 times, and none of the wheels in any of the runs were corrupted. In contrast, 6 out of 10 runs with the previous build workflow had at least one wheel that was corrupted. Corruption was determined by checking if the wheel files would unzip, since a wheel file is a ZIP archive under the hood.