[1105] Change Data Feed - PR 2 - DELETE command #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- correctly calculate numCopiedRows metric in DeleteCommand - add test in SchemaUtilsSuite - add metrics/stats to OptTxn and DeleteCmd - added committer.changeFiles to OptTxn - Add DeleteCDCSuite; add CDC codes in SchemaUtils - add cdc deletes to DeleteCommand.scala - perform CDC partitioning in TransactionalWrite GitOrigin-RevId: 7465d9aee506b29cfce5ed6cd9b8f86288b34f11
tdas
reviewed
May 11, 2022
core/src/main/scala/org/apache/spark/sql/delta/OptimisticTransaction.scala
Show resolved
Hide resolved
tdas
reviewed
May 11, 2022
core/src/main/scala/org/apache/spark/sql/delta/commands/DeleteCommand.scala
Outdated
Show resolved
Hide resolved
tdas
reviewed
May 11, 2022
core/src/main/scala/org/apache/spark/sql/delta/commands/DeleteCommand.scala
Outdated
Show resolved
Hide resolved
tdas
reviewed
May 11, 2022
| numFilesToRewrite: Long): Seq[FileAction] = { | ||
| val writeCdc = DeltaConfigs.CHANGE_DATA_FEED.fromMetaData(txn.metadata) | ||
|
|
||
| val numTouchedRows = metrics("numTouchedRows") |
There was a problem hiding this comment.
what does "touched" mean in this case?
There was a problem hiding this comment.
number of total rows that we have seen / are either copying or deleting (sum of both).
There was a problem hiding this comment.
Please put inline comment. This is not obvious.
tdas
reviewed
May 11, 2022
core/src/main/scala/org/apache/spark/sql/delta/schema/SchemaUtils.scala
Outdated
Show resolved
Hide resolved
tdas
reviewed
May 11, 2022
respond to PR comments
tdas
reviewed
May 12, 2022
core/src/main/scala/org/apache/spark/sql/delta/files/TransactionalWrite.scala
Outdated
Show resolved
Hide resolved
tdas
approved these changes
May 12, 2022
GitOrigin-RevId: 316cb8b05e9f87c3c4c377b6608f0eb237cd60ca
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
See the project plan at(delta-io#1105). This PR adds CDF write functionality to the DELETE command, as well as a test suite `DeleteCDCSuite`. At a high level, during the DELETE command, when we realize that we need to delete some rows in some files (but not the entire file), then instead of creating a new DataFrame which just contains the non-deleted rows (thus, in this new delta version, the previous rows were logically deleted), we instead partition the DataFrame into CDF-deleted columns and non-deleted columns. Then, when writing out the parquet files, we write the CDF-deleted columns into their own CDF parquet file, and we write the non deleted rows into a standard main-table parquet file (same as usual). We then also add an extra `AddCDCFile` action to the transaction log. Closes delta-io#1125. GitOrigin-RevId: 7934de886589bf3d70ce81dcf9d7de598e35fb2e
jbguerraz
pushed a commit
to jbguerraz/delta
that referenced
this pull request
Jul 6, 2022
See the project plan at(delta-io#1105). This PR adds CDF write functionality to the DELETE command, as well as a test suite `DeleteCDCSuite`. At a high level, during the DELETE command, when we realize that we need to delete some rows in some files (but not the entire file), then instead of creating a new DataFrame which just contains the non-deleted rows (thus, in this new delta version, the previous rows were logically deleted), we instead partition the DataFrame into CDF-deleted columns and non-deleted columns. Then, when writing out the parquet files, we write the CDF-deleted columns into their own CDF parquet file, and we write the non deleted rows into a standard main-table parquet file (same as usual). We then also add an extra `AddCDCFile` action to the transaction log. Closes delta-io#1125. GitOrigin-RevId: 7934de886589bf3d70ce81dcf9d7de598e35fb2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the project plan at #1105.
This PR adds CDF write functionality to the DELETE command, as well as a test suite DeleteCDCSuite. At a high level, during the DELETE command, when we realize that we need to delete some rows in some files (but not the entire file), then instead of creating a new DataFrame which just contains the non-deleted rows (thus, in this new delta version, the previous rows were logically deleted), we instead partition the DataFrame into CDF-deleted columns and non-deleted columns.
Then, when writing out the parquet files, we write the CDF-deleted columns into their own CDF parquet file, and we write the non deleted rows into a standard main-table parquet file (same as usual). We then also add an extra AddCDCFile action to the transaction log.