-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Delta-Iceberg] Fix delta-iceberg jar to not pull in delta-spark and delta-storage jars #2022
Closed
scottsand-db
wants to merge
6
commits into
delta-io:master
from
scottsand-db:1903_fix_delta_iceberg_jar
Closed
[Delta-Iceberg] Fix delta-iceberg jar to not pull in delta-spark and delta-storage jars #2022
scottsand-db
wants to merge
6
commits into
delta-io:master
from
scottsand-db:1903_fix_delta_iceberg_jar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdas
reviewed
Sep 5, 2023
tdas
reviewed
Sep 6, 2023
tdas
reviewed
Sep 6, 2023
tdas
reviewed
Sep 6, 2023
scottsand-db
commented
Sep 6, 2023
vkorukanti
reviewed
Sep 11, 2023
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the package name and the file path don't seem to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #1903
Previously, the
delta-iceberg
jar was incorrectly including all of the classes fromdelta-spark
anddelta-storage
.You could run
and see
This PR fixes that by updating various SBT assembly configs:
assemblyExcludedJars
: excluding jars we don't want (but this only works for jars fromlibraryDependencies
, not.dependsOn
)assemblyMergeStrategy
: manually discarding other classes using case matchingHow was this patch tested?
Unit Test
Added a new test suite and sbt project. The new project depends on the assembled version of the
delta-iceberg
jar. The test suite loads that jar and analyses its classes.QA
Published the jars locally and ran through a simple end-to-end UniForm example.
Does this PR introduce any user-facing changes?
Fixes a bug where delta-iceberg jar included delta-spark and delta-storage