[Spark][Sharing] Add CDF support for "delta format sharing" #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
requested changes
Jan 9, 2024
done |
vkorukanti
approved these changes
Jan 10, 2024
sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingCDFUtils.scala
Outdated
Show resolved
Hide resolved
sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingCDFUtils.scala
Outdated
Show resolved
Hide resolved
sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingCDFUtils.scala
Show resolved
Hide resolved
sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingCDFUtils.scala
Show resolved
Hide resolved
sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingLogFileSystem.scala
Outdated
Show resolved
Hide resolved
| startingMetadataLineOpt = Some(metadata.deltaMetadata.json + "\n") | ||
| } | ||
| case protocol: model.DeltaSharingProtocol => | ||
| startingProtocolLineOpt = Some(protocol.deltaProtocol.json + "\n") |
There was a problem hiding this comment.
do we expect to get only one protocol action from the server? what if we have multiple protocol actions (due to alter etc) in the log files between starting and end version?
There was a problem hiding this comment.
good question, the answer is two fold:
- The server performs basic checks that the recipient/client is able to handle the readerFeatures, and throw error if not.
- The rest of the job is left to the client side delta library, and fallback to the same delta behavior. if delta cannot handle it, it throws the same error as reading a delta table, such as error when reading cdf on a table with column name changed.
sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingLogFileSystem.scala
Show resolved
Hide resolved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Third PR of #2291: Adds CDF support for "delta format sharing":
How was this patch tested?
Unit Tests
Does this PR introduce any user-facing changes?
No