Allow file names to include = when convert to delta #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lys0716 can you rebase your branch with latest delta master. |
|
|
|
@rahulsmahadev Thanks! Updated. |
| val (partitionOpt, _) = PartitionUtils.parsePartition( | ||
| path, |
There was a problem hiding this comment.
if path is no longer used, we do not need to have it.
There was a problem hiding this comment.
The path store the absolute path to a file. It is used later to create an AddFile action. But we don't need it to parse the partition in the directory.
There was a problem hiding this comment.
Hi @rahulsmahadev please let me know if you have other comments on this pr.
Allow file names to include = when convert to delta Signed-off-by: Yishuang Lu <luystu@gmail.com>
zsxwing
approved these changes
Jan 7, 2020
tdas
pushed a commit
to tdas/delta
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow file names to include = when convert to delta
Signed-off-by: Yishuang Lu luystu@gmail.com