[Spark] Protocol version downgrade in the presence of table features #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xupefei
reviewed
Apr 3, 2024
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
xupefei
reviewed
Apr 3, 2024
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
xupefei
reviewed
Apr 3, 2024
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
larsk-db
reviewed
Apr 4, 2024
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
|
Is the description correct? Reader v1 doesn’t support DV |
I think the intent of "can be downgraded" was an implicit "after removing the DV feature". |
bart-samwel
reviewed
Apr 23, 2024
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
andreaschat-db
force-pushed
the
downgradeMinTableFeatureVersion
branch
from
d9d7845
to
3a4db9e
Compare
bart-samwel
reviewed
May 10, 2024
spark/src/main/scala/org/apache/spark/sql/delta/actions/TableFeatureSupport.scala
Outdated
Show resolved
Hide resolved
5 tasks
bart-samwel
approved these changes
May 13, 2024
spark/src/test/scala/org/apache/spark/sql/delta/DeltaProtocolVersionSuite.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR adds support for protocol versions downgrade when table features exist in the protocol. The downgraded protocol versions should be the minimum required to support all available table features. For example,
Protocol(3, 7, DeletionVectors, RowTracking)can be downgraded toProtocol(1, 7, RowTracking)after removing the DV feature.How was this patch tested?
Added new UTs in DeltaProtocolVersionSuite. Furthermore, existing UTs cover a significant part of the functionality. These these are the following:
Does this PR introduce any user-facing changes?
Yes. Dropping a table feature from a table with multiple features may now result to a Protocol versions downgrade. For example,
Protocol(3, 7, DeletionVectors, RowTracking)can now be downgraded toProtocol(1, 7, RowTracking).