[Kernel][Writes] Add schema validation utils #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
requested changes
May 1, 2024
| } | ||
|
|
||
| /** | ||
| * Returns all column names in this schema as a flat list. For example, a schema like: | - a | | |
There was a problem hiding this comment.
I can't really easily read or understand | - a | | - 1 | | - 2 | - b | - c | | - nest | | - 3
Can you make this multi line and in a tree format?
There was a problem hiding this comment.
This is because of Intellij auto-format. Added <pre> tag to avoid formatting this block.
| if (uniqueColNames.size() != flattenColNames.size()) { | ||
| String duplicateColumns = flattenColNames.stream() | ||
| .map(String::toLowerCase) | ||
| .filter(n -> !uniqueColNames.add(n)) |
There was a problem hiding this comment.
Isn't every element of flattenColNames already in uniqueColNames ?
so won't uniqueColNames.add(n) return false every time?
There was a problem hiding this comment.
You are right. This should be a new set. Added a test to match the error message exactly to contain only the duplicate column names.
kernel/kernel-api/src/main/java/io/delta/kernel/internal/util/SchemaUtils.java
Outdated
Show resolved
Hide resolved
scottsand-db
approved these changes
May 1, 2024
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
May 1, 2024
(Split from the larger PR delta-io#2944) These are utility to make sure the given schema when creating the table is valid (has no duplicate column names or invalid chars). The code/logic is similar to Delta-Spark/Standalone. Unittests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Split from the larger PR #2944)
These are utility to make sure the given schema when creating the table is valid (has no duplicate column names or invalid chars). The code/logic is similar to Delta-Spark/Standalone.
How was this patch tested?
Unittests