[Kernel][Writes] Allow transaction retries for blind append #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
changed the title
vkorukanti
force-pushed
the
conflictResolution
branch
from
ccb8bd7 to
4b8b482
Compare
scottsand-db
reviewed
May 6, 2024
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ConflictChecker.java
Outdated
Show resolved
Hide resolved
scottsand-db
approved these changes
May 6, 2024
scottsand-db
reviewed
May 6, 2024
kernel/kernel-api/src/main/java/io/delta/kernel/internal/TransactionImpl.java
Outdated
Show resolved
Hide resolved
vkorukanti
added a commit
that referenced
this pull request
May 6, 2024
Currently, Kernel throws an exception when there is a conflict (i.e., there already exists a committed file at a given version). We should retry the transaction as the current support is just for blind appends. Retry checks if there are no logical conflicts (`metadata`, `protocol` or `txn` (Set Tranaction)) conflicts that affect the blind append. Tests for protocol, metadata and setTxn conflicts. Also tests to verify blind appends are retried and committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Kernel throws an exception when there is a conflict (i.e., there already exists a committed file at a given version). We should retry the transaction as the current support is just for blind appends. Retry checks if there are no logical conflicts (
metadata,protocolortxn(Set Tranaction)) conflicts that affect the blind append.How was this patch tested?
Tests for protocol, metadata and setTxn conflicts. Also tests to verify blind appends are retried and committed.