[Spark] InCommitTimestamp: Use clock.currentTimeMillis() instead of nanoTime() in commitLarge #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Map.empty) | ||
| } | ||
| val ver1Snapshot = deltaLog.snapshot | ||
| val retrievedTimestamp = getInCommitTimestamp(deltaLog, 1) |
There was a problem hiding this comment.
[nit] used named parameter.
prakharjain09
approved these changes
May 17, 2024
| @@ -143,6 +143,33 @@ class InCommitTimestampSuite | |||
| } | |||
| } | |||
|
|
|||
| test("commitLarge should use clock.currentTimeMillis() for ICT") { | |||
There was a problem hiding this comment.
Could we have a similar test for txn.commit API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
We currently use NANOSECONDS.toMillis(System.nanoTime()) for generating the ICT when
commitLargeis called. However, this usage of System.nanoTime() is not correct as it should only be used for measuring time difference, not to get an approximate wall clock time. This leads to scenarios where the ICT becomes very small (e.g. 1 Jan 1970) sometimes because some systems return a very small number when System.nanoTime() is called. This PR changes this so that clock.getCurrentTimeMillis() is used instead.How was this patch tested?
Added a test case to ensure that
clock.getCurrentTimeMillis()is being used.Does this PR introduce any user-facing changes?
No