[Spark][Backport 3.2] Fix the semantic of shouldRewriteToBeIcebergCompatible in REORG UPGRADE UNIFORM
#3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EORG UPGRADE UNIFORM (delta-io#3412) ## Description currently we utilize the helper function `shouldRewriteToBeIcebergCompatible` to filter the portion of parquet files that need to be rewritten when running `REORG UPGRADE UNIFORM` based on the tags in the `AddFile`. however, the `DeltaUpgradeUniformOperation.icebergCompatVersion` is accidentally shadowed, which will make `shouldRewriteToBeIcebergCompatible` always return `false` if the `AddFile.tags` is not `null` - this is not the expected semantic of this function. this PR introduces the fix for this problem and add unit tests to ensure the correctness. ## How was this patch tested? through unit tests in `UniFormE2ESuite.scala`. ## Does this PR introduce _any_ user-facing changes? no.
xzhseh
changed the title
shouldRewriteToBeIcebergCompatible in REORG UPGRADE UNIFORMshouldRewriteToBeIcebergCompatible in REORG UPGRADE UNIFORM
johanl-db
approved these changes
Aug 5, 2024
|
these are known python test infra issue failures. since java tests passed, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
currently we utilize the helper function
shouldRewriteToBeIcebergCompatibleto filter the portion of parquet files that need to be rewritten when runningREORG UPGRADE UNIFORMbased on the tags in theAddFile.however, the
DeltaUpgradeUniformOperation.icebergCompatVersionis accidentally shadowed, which will makeshouldRewriteToBeIcebergCompatiblealways returnfalseif theAddFile.tagsis notnull- this is not the expected semantic of this function.this PR introduces the fix for this problem and add unit tests to ensure the correctness.
How was this patch tested?
through unit tests in
UniFormE2ESuite.scala.Does this PR introduce any user-facing changes?
no.