add supporting remove partitions if delta was partitioned #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brkyvz
reviewed
Apr 17, 2020
| @@ -79,8 +79,7 @@ trait ImplicitMetadataOperation extends DeltaLogging { | |||
| def isNewSchema: Boolean = txn.metadata.schema != mergedSchema | |||
| // We need to make sure that the partitioning order and naming is consistent | |||
| // if provided. Otherwise we follow existing partitioning | |||
| def isNewPartitioning: Boolean = normalizedPartitionCols.nonEmpty && | |||
| txn.metadata.partitionColumns != normalizedPartitionCols | |||
| def isNewPartitioning: Boolean = txn.metadata.partitionColumns != normalizedPartitionCols | |||
There was a problem hiding this comment.
you need a more intricate condition here:
normalizedPartitionCols.nonEmpty && txn.metadata.partitionColumns != normalizedPartitionColsORoverwriteSchema && txn.metadata.partitionColumns != normalizedPartitionCols
There was a problem hiding this comment.
i indroduced new variable for it
brkyvz
reviewed
Apr 17, 2020
| .format("delta") | ||
| .partitionBy("by4") | ||
| .save(tempDir.toString) | ||
|
|
There was a problem hiding this comment.
can you also add a check that the partitioning column indeed did exist
There was a problem hiding this comment.
check was added
brkyvz
approved these changes
Apr 20, 2020
tdas
pushed a commit
that referenced
this pull request
Apr 22, 2020
…rtitioned It is PR for issue with removing partitions in delta table. It was discussed here https://delta-users.slack.com/archives/CJ70UCSHM/p1587048581235000 And i implemened proposed solution https://delta-users.slack.com/archives/CJ70UCSHM/p1587068793244400 Closes #390 Co-authored-by: hleb.lizunkou <hleb.lizunkoui@coxautoinc.com> Signed-off-by: Burak Yavuz <brkyvzgmail.com> GitOrigin-RevId: eee5573959bc9827f1d381133cde45685f8dbee4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is PR for issue with removing partitions in delta table.
It was discussed here https://delta-users.slack.com/archives/CJ70UCSHM/p1587048581235000
And i implemened proposed solution https://delta-users.slack.com/archives/CJ70UCSHM/p1587068793244400