Add "@since" to DeltaMergeMatchedActionBuilder.delete() #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFFogarty
changed the title
|
Thank you for catching this! This was an oversight on our part. Can you also add the Evolving tag |
|
@tdas Added the |
LantaoJin
pushed a commit
to LantaoJin/delta
that referenced
this pull request
Jun 15, 2021
…elete() This small PR adds a `@since 0.3.0` annotation to `DeltaMergeMatchedActionBuilder.delete()`, which seems to be the only public API function missing this. I also noticed that this function is missing a `@Evolving` tag. Is this intentional? CC: @rapoth @suhsteve @imback82 Closes delta-io#493 Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com> Author: Tathagata Das <tathagata.das1565@gmail.com> Author: Andrew Fogarty <andrew.f.fogarty@gmail.com> #12210 is resolved by tdas/8wg7e9nq. GitOrigin-RevId: e55fd064c923186d349c8c6078a3d5fc4ed375b4 (cherry picked from commit 4498e20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adds a
@since 0.3.0annotation toDeltaMergeMatchedActionBuilder.delete(), which seems to be the only public API function missing this.I also noticed that this function is missing a
@Evolvingtag. Is this intentional?CC: @rapoth @suhsteve @imback82