[Kernel Spark]Make Spark's Catalog table as a params for creating the dsv2 connector. #5428
+165
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param options table options used to configure the Hadoop conf, table reads and writes | ||
| * @throws NullPointerException if identifier or tablePath is null | ||
| */ | ||
| public SparkTable(Identifier identifier, String tablePath, Map<String, String> options) { |
There was a problem hiding this comment.
Shall we keep the previous constructor? Otherwise we can't read file path table with options
| * @throws NullPointerException if identifier or tablePath is null | ||
| */ | ||
| public SparkTable(Identifier identifier, String tablePath, Map<String, String> options) { | ||
| private SparkTable(Identifier identifier, String tablePath, Optional<CatalogTable> catalogTable) { |
There was a problem hiding this comment.
Also, when catalogTable is available, we should get the schema and partitioning from it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
In parts of catalog integration, e.g. unity catalog, we notice that the catalog plugin will encapsulate the table in the catalog using spark's CatalogTable classes, so we introduce a new constructor to create a dsv2 connector based on spark's catalog.
As a part of the changes, fix the usage of
optionit represents the addition properties that we want to pass to the hadoop fs for data read and write, so it make more sense to be inferred from the catalogTable.storage.properties than provided arbitrarily and shouldn't be shown as table propertiesHow was this patch tested?
Updated test
Does this PR introduce any user-facing changes?
No