[MINOR] Use Literal constants #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That should lower memory requirements (as no extra objects are created) and improve readability Signed-off-by: Jacek Laskowski <jacek@japila.pl>
jaceklaskowski
force-pushed
the
literal-constants
branch
from
4a2f92c to
a0d2b93
Compare
mengtong-db
reviewed
Mar 30, 2021
Comment on lines
580
to
587
| Literal(null) | ||
| } else { | ||
| Literal.create(unescapePathName(raw), StringType) | ||
| } | ||
| } | ||
| } else { | ||
| if (raw == DEFAULT_PARTITION_NAME) { | ||
| Literal.create(null, NullType) | ||
| Literal(null) |
There was a problem hiding this comment.
nit: Maybe it's better to keep the create() call in these two places? It makes it more clear that converting to catalyst types are needed here, although for null it's no-op
mengtong-db
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should lower memory requirements (as no extra objects are created) and improve readability
Signed-off-by: Jacek Laskowski jacek@japila.pl