Convert Delta into a multi module SBT project #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdas
commented
Apr 7, 2021
|
|
||
| import ReleaseTransformations._ | ||
| // Looks like some of release settings should be set for the root project as well. |
There was a problem hiding this comment.
inspired from the connectors repo build.sbt - https://github.com/delta-io/connectors/blob/master/build.sbt#L110
tdas
commented
Apr 7, 2021
| * Unidoc settings * | ||
| *******************/ | ||
|
|
||
| enablePlugins(GenJavadocPlugin, JavaUnidocPlugin, ScalaUnidocPlugin) |
There was a problem hiding this comment.
moved this to the core project settings
tdas
commented
Apr 7, 2021
|
|
||
| /** ******************** | ||
| /* |
There was a problem hiding this comment.
these changes are to make scalastyle happy
tdas
changed the title
Merged
yijiacui-db
pushed a commit
that referenced
this pull request
Apr 19, 2021
Making Delta a multi-module project will enable us to add other sub-modules. For example, we can then add a contribs sub-module that can have contributions from the community that needs to be very closely tied to the delta-core project (hence in this repo, and not delta/connectors) but does not have the same level of maturity as delta-core. Changes made in the Delta repeeo - Moved all files in root/src/ to root/core/src/ - update build.sbt to multiple modules - Removed dependency on spark-packages. existing tests Closes #644 Author: Tathagata Das <tathagata.das1565@gmail.com> GitOrigin-RevId: 68038d27302e82f6e680fe717633109757e48ba0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making Delta a multi-module project will enable us to add other sub-modules. For example, we can then add a contribs sub-module that can have contributions from the community that needs to be very closely tied to the delta-core project (hence in this repo, and not delta/connectors) but does not have the same level of maturity as delta-core.
Changes made in this