scalastyle:on Locale.ROOT missing for some toLowerCase and throwerror => unable to build #84
Conversation
…able paths In this PR, I added exception handling for `forPath` method in `DeltaTable.scala`. After the change, Delta Table will make sure create instance just for "Delta Source", other sources will throw an exception. This PR is tested by `DeltaTableSuite.scala` Closes #79 Closes #5599 from tdas/qy70ntky. Lead-authored-by: Zhitong Yan <zhitong.yan@databricks.com> Co-authored-by: Tathagata Das <tdas@databricks.com> Co-authored-by: ZhitongDB <50844714+ZhitongDB@users.noreply.github.com> Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com> GitOrigin-RevId: eb3a014714aacc1b97d165089e610186b1bb9f83
details - added local where needed - added better ignore to both condition of it
small fix to make build to work
|
Mario_Amatucci seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| } else { | ||
| // scalastyle:off throwerror |
There was a problem hiding this comment.
as it is it does not work
likely because it s an IF
| @@ -157,7 +158,7 @@ object SchemaUtils { | |||
| def checkColumnNameDuplication(schema: StructType, colType: String): Unit = { | |||
| val columnNames = explodeNestedFieldNames(schema) | |||
| // scalastyle:off caselocale | |||
| val names = columnNames.map(_.toLowerCase) | |||
| val names = columnNames.map(_.toLowerCase(Locale.ROOT)) | |||
| @@ -715,7 +715,8 @@ private[delta] object PartitionUtils { | |||
| def checkColumnNameDuplication( | |||
| columnNames: Seq[String], colType: String, caseSensitiveAnalysis: Boolean): Unit = { | |||
| // scalastyle:off caselocale | |||
| val names = if (caseSensitiveAnalysis) columnNames else columnNames.map(_.toLowerCase) | |||
| val names = if (caseSensitiveAnalysis) columnNames else | |||
|
@obar1 Thanks for your contribution. Could you provide the command that can reproduce the style check error? I tested locally and didn't find any error. |
|
I checked out as it is - after git clone |
|
the error scalastyle are related to the lack of proper LOCAL and the throw exception - my version is probably safer than current anyway - do a |
|
So the issue is |
|
hi @zsxwing |
… in Union rewrite (delta-io#84)
#83
https://delta-users.slack.com/archives/CJ70UCSHM/p1562335559156800