Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor js #17

Open
thumbnail opened this issue Oct 9, 2018 · 2 comments
Open

Refactor js #17

thumbnail opened this issue Oct 9, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@thumbnail
Copy link
Member

refactoring svgbuilder.js should use classes in order to remove more duplication.
we should also refactor main.js to make the navigation clearer.
@hampterhub
Copy link
Contributor

agreed, it can be improved a lot and there is stuff like the animationRef that can be removed. not sure about classes, if you still want to implement IE then best we can do are prototypes or modules.

If IE isnt an issue then the only thing i have to comment on would be that i think the specific animation functions wont fit well as a class but maybe we can abstract it to a set of instructions like the svgblueprint

@thumbnail
Copy link
Member Author

Since we add browserify / babelify in #14, it gets transpiled to es2015 anyway, so we can use (most of) the features afaik.

@thumbnail thumbnail added the enhancement New feature or request label Oct 9, 2018
@rafaelklaessen rafaelklaessen mentioned this issue Oct 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thumbnail @hampterhub