-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce gulp #14
Introduce gulp #14
Conversation
gulpfile.js
Outdated
|
||
exports.css = (cb) => { | ||
gulp.src('_css/**/*.?(s)css') | ||
.pipe(sourcemaps.init()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert to pump
this broke particleJS
gulpfile.js
Outdated
gulp.dest('dist')], cb); | ||
}; | ||
|
||
exports.js = (cb) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be nicer to use one export
exports.build = series(
clean,
parallel(
cssTranspile,
series(jsTranspile, jsBundle)
),
parallel(cssMinify, jsMinify),
publish
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described in the description of the PR there's still a build
-task to be made, which combines both.
I'd like the css and js tasks to be available independent of eachother anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if you export everything at ones they should be available as their own tasks using gulp [task name]
wouldn't it be to use gulp-watch, then you can also set the server parameters. |
you can pass configuration using the |
what about:
Then: |
.circleci/config.yml
Outdated
command: gem install jekyll | ||
command: | | ||
gem install jekyll | ||
sudo npm install --global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just do npm install
. Thats all you need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what you do, is create the npm command I commented, then just require gulp
3.x and then change line 21 to npm run gulp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"gulp-autoprefixer": "^6.0.0", | ||
"gulp-babel": "^8.0.0", | ||
"gulp-clean-css": "^3.10.0", | ||
"gulp-cli": "^2.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't seem to work without, but since i explicitly install it in the circleci config I might be able to delete it. also more people suggest gulp-cli is needed
regarding the |
Then you don't have to install a lot of unrelated packages, or install things globally in the CI (use containers with the specific tools already pre installed). You can ofcourse run the commands from your ci config file. But why not add it as a nice npm run 'command'. It was just another solution to the problem. There are meerdere wegen to Rome |
* Removing things until it stops braking * removed first npm install * added npm gulp task, removed installation of gulp_cli npm run gulp ================= npm run adds node_modules to the path, $arg holds any arguments sent with gulp. * removed `sudo`, changed script run command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Fixes #3, also closes #4
css
taskjs
taskvar
somewhere)serve
taskbuild
task that just puts all the files in in one folderResults
the site is at best about 150ms faster. it doesn't matter a lot though. It was mostly practise and wider support for es6 that #3 addressed.