Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENTAL] IE support #9

Closed
wants to merge 3 commits into from
Closed

[EXPERIMENTAL] IE support #9

wants to merge 3 commits into from

Conversation

thumbnail
Copy link
Member

@thumbnail thumbnail commented Oct 5, 2018

based on #7 and #8, needs to be rebased.

goals

  • js compatibility
    • this is quite easy; just use 2015 (e.g. no for..on, NodeList#forEach, or arrow functions)
  • css compatibility
    • ran autoprefixer

ended up with:
afbeelding
afbeelding

which might be workable, but i'm sceptical about using css grid for this site now. if we want to support IE we'll have to drop it

@thumbnail thumbnail changed the base branch from master to refactor-more October 5, 2018 12:12
@thumbnail thumbnail mentioned this pull request Oct 5, 2018
@hampterhub
Copy link
Contributor

question is do we really want to support something like IE, not that i mind supporting edge but the scope of things needed to be done for IE bring benefits to only a small amount of users.

@thumbnail
Copy link
Member Author

I don't think IE11 is that hard to support, it's just replacing display: grid. the es2015-stuff can be reverted once the pipeline (#3) works, so that's temporary.

I'm not sure what's wrong with Edge; neither do i have a machine to test it with.

@romnous what do you think about IE11 support?

@thumbnail
Copy link
Member Author

JS is superseded by #14. CSS fix is a different issue, adding to #4

@thumbnail thumbnail closed this Oct 5, 2018
@thumbnail thumbnail deleted the ie-support branch October 8, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants