forked from delta/codecharacter-server-2022
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(Update game entities): Updated Attackers and Defenders #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aerial attribute
why did u delete pre-commit.sh?. |
Ram-20062003
requested changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Requested
- Fix the parameter namings and change it wherever it is being used
server/src/main/kotlin/delta/codecharacter/server/params/game_entities/Attacker.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/delta/codecharacter/server/params/game_entities/Defender.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
============================================
+ Coverage 47.43% 48.17% +0.73%
- Complexity 280 282 +2
============================================
Files 85 85
Lines 1619 1644 +25
Branches 157 157
============================================
+ Hits 768 792 +24
- Misses 801 802 +1
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ram-20062003
approved these changes
Feb 18, 2023
Ashwin125
approved these changes
Feb 18, 2023
b1otch
added a commit
that referenced
this pull request
Feb 19, 2023
* update(updated game entities): Updated Attackers and Defenders, Added aerial attribute * fix: Re-Add deleted hooks * fix(Attacker and Defender attributes): Updated attribute names * fix: namings for game-parameters --------- Co-authored-by: Ram-20062003 <ramajs2003@gmail.com> Co-authored-by: Ram Ganesh K. R <83528327+Ram-20062003@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Attackers and Defenders