Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(Update game entities): Updated Attackers and Defenders #17

Merged
merged 6 commits into from
Feb 18, 2023

Conversation

b1otch
Copy link

@b1otch b1otch commented Feb 10, 2023

Updated Attackers and Defenders

  • Updated the attacker and defender values
  • Added aerial attribute

@Ram-20062003
Copy link
Collaborator

why did u delete pre-commit.sh?.

Copy link
Collaborator

@Ram-20062003 Ram-20062003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested

  • Fix the parameter namings and change it wherever it is being used

@codecov-commenter
Copy link

Codecov Report

Merging #17 (8f12518) into main (264107c) will increase coverage by 0.73%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #17      +/-   ##
============================================
+ Coverage     47.43%   48.17%   +0.73%     
- Complexity      280      282       +2     
============================================
  Files            85       85              
  Lines          1619     1644      +25     
  Branches        157      157              
============================================
+ Hits            768      792      +24     
- Misses          801      802       +1     
  Partials         50       50              
Impacted Files Coverage Δ
...a/codecharacter/server/config/GameConfiguration.kt 100.00% <100.00%> (ø)
...echaracter/server/params/game_entities/Attacker.kt 100.00% <100.00%> (ø)
...echaracter/server/params/game_entities/Defender.kt 100.00% <100.00%> (ø)
...lin/delta/codecharacter/server/game/GameService.kt 93.47% <0.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Ram-20062003 Ram-20062003 merged commit 56363ca into main Feb 18, 2023
b1otch added a commit that referenced this pull request Feb 19, 2023
* update(updated game entities): Updated Attackers and Defenders, Added aerial attribute

* fix: Re-Add deleted hooks

* fix(Attacker and Defender attributes): Updated attribute names

* fix: namings for game-parameters

---------

Co-authored-by: Ram-20062003 <ramajs2003@gmail.com>
Co-authored-by: Ram Ganesh K. R <83528327+Ram-20062003@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants