Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure more things in config.json #105

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

MeesoPost
Copy link
Contributor

@MeesoPost MeesoPost commented Nov 13, 2024

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
signalen-frontend-wcag ❌ Failed (Inspect) Nov 28, 2024 3:31pm

@Robbert
Copy link
Contributor

Robbert commented Nov 18, 2024

Ik ga nog:

  • map marker code aanpassen dat het via design tokens werkt, niet via config
  • i18n teksten weer gedeeltelijk terugplaatsen, alleen de teksten in config.json overblijven die specifiek zijn voor een organisatie
  • en.json en nl.json valideren met nieuwe TypeScript type

@Robbert Robbert force-pushed the feat/translate-alert branch from dbd1fba to ea48af8 Compare November 27, 2024 15:38
@Robbert Robbert changed the title Config-theme feat: configure more things in config.json Nov 27, 2024
@Robbert
Copy link
Contributor

Robbert commented Nov 27, 2024

@justiandevs dit is de todo waar ik het over had. "Het werkt" nu, maar je wil misschien eigenlijk de config.json op een andere manier laden.

https://github.com/delta10/signalen-frontend-wcag/pull/105/files#diff-d387de9ed27220b8f151f3debc731746f2804b3e509aa2f99de6d40137df203aR21-R22

# Conflicts:
#	src/app/[locale]/components/Header.tsx
#	src/app/[locale]/incident/add/page.tsx
#	src/app/[locale]/incident/components/IncidentDescriptionPage.tsx
#	src/app/[locale]/incident/contact/page.tsx
#	src/app/[locale]/incident/summary/page.tsx
#	src/app/[locale]/layout.tsx
#	src/app/globals.css
#	translations/en.json
fix: merge with master
@@ -0,0 +1,146 @@
// todo: check I18nConfig once we have settled on a more robust language dictionary structure
Copy link
Member

@bartjkdp bartjkdp Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We gebruiken een andere library ;). https://next-intl-docs.vercel.app/docs/workflows/typescript dit is een stuk gemakkelijker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb mijn comment hierboven aangepast.

@justiandevs justiandevs merged commit 9fd98e1 into main Nov 29, 2024
2 of 5 checks passed
@justiandevs justiandevs deleted the feat/translate-alert branch November 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants