Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/225 Alert to SpotlightSection Component #267

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

TessaViergever
Copy link
Contributor

@TessaViergever TessaViergever commented Dec 12, 2024

Hoort bij issue #225

In deze PR

  • <SpotlightSection> Component toevoegen aan index.ts
  • Component wisselen voor <SpotlightSection> Component op IncidentDescriptionPage.tsx
Scherm­afbeelding 2024-12-12 om 10 19 03

⚠️ Contrast issue #241 is "opgelost". Door gebruik van SpotlightSection is de Alert styling komen te vervallen en daarmee ook de contrast issues. SpotlightSection styling moet nog wel toegevoegd worden. @Marwaxhello voegt deze tokens toe aan het Purmerend thema, zij let hierbij gelijk op contrast. 💪🏼

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
signalen-frontend-wcag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 10:13am

@justiandevs justiandevs merged commit 0ef1561 into main Dec 12, 2024
5 checks passed
@justiandevs justiandevs deleted the refactor/225-alert-to-spotlight branch December 12, 2024 10:15
@TessaViergever TessaViergever linked an issue Dec 12, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.1.3 onnodig statusbericht role=alert
2 participants