-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/config themes #98
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MeesoPost
force-pushed
the
feat/config-themes
branch
from
November 12, 2024 09:02
96db835
to
48ea5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme Config
Refactored header component from feedback given in PR #75
added 2 themes with comments from Aantal instellingen configurabel maken in config.json #82
Updated [Locale] layout to use async functions for translation
added logo for Gemeente Voorbeeld theme
installed Gemeente Voorbeeld design tokens
merged my new config.json with the old one
Fixed a error caused by changed i made, i added a ? to the color variable
Before
color={config.base.style.primaryColor}
After
color={config.base.style?.primaryColor}
use. getTranslation instead of useTranslation and updated import to come from next-intl/server
added exmaple/test for translated version of the alert
TODO
in Aantal instellingen configurabel maken in config.json #82