store devicetokens inside per-user mailboxdir, allow multiple tokens per account, support GETMETADATA and add tests #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
changed the title
link2xt
approved these changes
Mar 28, 2024
link2xt
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #243
As discussed here it is possible to know the mailbox-dir for metadata get/set requests so this PR sets/gets devicetokens accordingly.
This means that a mailbox-dir (the inbox folder of a user basically) contains also the metadata, now in the "metadata.marshalled" file in the inbox folder.
The data is persisted using the builtin "marshal" module and guarded by an os-level file lock.
The PR also adds both local as well as online tests, and adds support for GETMETADATA.