notify webxdc events, replies and reactions to own messages even if chat is muted #3456

adbenitez · 2024-11-29T19:16:03Z

even if group is muted:

notify quote-reply to own messages
notify reactions to own messages
notify webxdc notifications

what is still unsolved:

if webxdc sends notification while the chat is open, there is no notification, if there is no info message there is no hint that there was a notification at all, and if there is info message that doesn't warranties that the notification was the same

github-actions · 2024-11-29T19:47:43Z

To test the changes in this pull request, install this apk:
📦 app-preview.apk

github-actions · 2024-11-30T12:43:17Z

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s · 2024-12-02T14:33:33Z

remove unnecessary thread

just wanted to comment on that :)

github-actions · 2024-12-02T14:48:32Z

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s · 2024-12-02T14:50:32Z

src/main/java/org/thoughtcrime/securesms/notifications/NotificationCenter.java

        final String name = JsonUtils.optString(info, "name");
        String shortLine = name.isEmpty()? text : (name + ": " + text);
-        maybeAddNotification(accountId, dcContext.getChat(dcMsg.getChatId()), msgId, shortLine, shortLine, false);
+        DcChat dcChat = dcContext.getChat(dcMsg.getChatId());
+        maybeAddNotification(accountId, dcChat, msgId, shortLine, shortLine, false, dcChat.isMultiUser());


how is that "mentioning" supposed to work?

if i understand the code correctly, that would result in any webxdc-notification to be treated as "mention" and bypass group-muting

that was the initial idea, but that was before "*" came in, oth, notifying all even if group is muted is still nice, and is similar to what happen in a muted group when someone uses the @all mention

and I can already see some similar use-cases like in an "announcements" app where the group is muted due to flood but when an important announcement is needed then someone can use the webxdc "*" to notify all of the event

I think that for webxdcs, isMention should either always be false or wasDirectlyNotified (i.e. not only with *). Because I think it would be quite annoying to get notifications XY added an event to the calendar all the time even though you muted the group, and look like a bug.

oth the event in the calendar could be important, ex. in work context, while the rest of the chat flood is kept away by the muted chat

btw we simply can't know if it was a direct mention or an "*" mention from current event, so "only notify direct mentions not @all" is simply not possible

what we could do to mitigate potential annoyances is to have a setting in notifications to disable notification of "mentions" and webxdc in muted chats, like I did for ArcaneChat:

While it still seems to be the "right" way not to notify here to me, we can't know until the feature is actually used and we get some real-life experience, (plus, I do see the advantages @adbenitez mentioned), so, I would also be fine with merging as-is

to move forward.

(Björn, 2024)

2024? he is moving forward since the 80s

Because I think it would be quite annoying to get notifications XY added an event to the calendar all the time even though you muted the group, and look like a bug.

agree, we should not do that.

in general, not sure to introduce these "mentions" last minute that the user cannot get rid of.

an option might be nice, but we should have that on all UI then, this is nothing for just now.

in general, not sure to introduce these "mentions" last minute that the user cannot get rid of.

the webxdc notifications in muted groups was intended since the very beginning or that was hpk told me, I am fine with not doing it, then notifications for webxdc will be lost since there is no way to read them later unlike with messages

r10s · 2024-12-02T16:24:52Z

as adding "mentions" last-minute without an option to really mute a chat are questionable. and, to do better, might also need help of core (which is also nothing helping getting releases out), i again, suggest to split the PR (in general, it is better to do PR that are doing one thing)

let's merge the is-foreground-thingie in
postpone mentions

adbenitez · 2024-12-02T17:03:02Z

created: #3460

adbenitez · 2024-12-02T17:04:40Z

to do better, might also need help of core

I am not sure it is better, notify ALL is also considered a mention in other platforms, and would break the workflow of the Calendar example I described above

adbenitez · 2024-12-02T17:13:49Z

I updated this PR, now this one is about the extra notifications in "mentions" situations in muted chats

r10s · 2024-12-02T17:24:35Z

I am not sure it is better, notify ALL is also considered a mention in other platforms, and would break the workflow of the Calendar example I described above

well, from that point of view every message could be regarded mention 🤷‍♂️ :)

question is, if a webxdc notify to "*" is more like Hello or @all Hello - so, a normal message that should be notified as any other message or a explicit mention

adbenitez · 2024-12-02T17:33:38Z

well, from that point of view every message could be regarded mention 🤷‍♂️ :)

question is, if a webxdc notify to "*" is more like Hello or @all Hello - so, a normal message that should be notified as any other message or a explicit mention

the property is called NOTIFY, so yes, it is more like @all msg, it is not like any normal chat message, which we might add the possibility to send from webxdc as already said here and there

r10s · 2024-12-02T17:47:08Z

~~at a first glance, the option is disabled by default, or?~~
~~as from another discussion ...~~
~~> if the chat is muted user will lose webxdc notifications without way to realize~~
~~... so that would still be true by default.~~
EDIT: tested, it is enabled by default

for *, if we regard that as a "mention" as well, indeed, no help from core would be needed, that's a little plus :)
otoh, well, indeed it is called NOTIFY but not MENTION - so allowing an webxdc to be "stronger" than a normal user-typed message is nothing we did up to now, maybe okay, just saying it is not that clear. i would also be interstee in what @Hocuri says - and @ALL just to test :)

github-actions · 2024-12-02T18:01:21Z

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s

some minor comments, i am fine with that in general, having a switch we can also experiment more :)

r10s · 2024-12-03T15:17:28Z

src/main/java/com/b44t/messenger/DcContext.java

@@ -211,6 +213,14 @@ protected void finalize() throws Throwable {
    public native boolean      isSendingLocationsToChat(int chat_id);
    public DcProvider          getProviderFromEmailWithDns (String email) { long cptr = getProviderFromEmailWithDnsCPtr(email); return cptr!=0 ? new DcProvider(cptr) : null; }

+    public boolean isMentionsEnabled() {
+      return !"0".equals(getConfig(CONFIG_MENTION_NOTIF_ENABLED));


while working, it is a bit hard to understand, every string by "0" means "enabled" then, so also "" (which is the default). getConfigInt() would not work as well, although used for setting.

suggestion: call the thing CONFIG_NOTIIFY_MENTIONS_IF_MUTED / ui.notify_mentions_if_muted, then the default of "" or 0 matches and we can use get/setConfigInt(), and that is also in sync with the other options

suggestion: call the thing CONFIG_NOTIIFY_MENTIONS_IF_MUTED / ui.notify_mentions_if_muted, then the default of "" or 0 matches and we can use get/setConfigInt(), and that is also in sync with the other options

renaming would be ok, but I don't see how it changes the problem, "" (unset) still needs to mean "1" (enabled) since it is the default, you want to "ui.notify_mentions_if_muted" to be on by default 🤔

I renamed it 👍 and I think I improved the code to be easier to understand now

but I don't see how it changes the problem

sorry, my fault 🤦‍♂️

i meant to inverse the meaning of the var, so CONFIG_MUTE_MENTIONS_IF_MUTED; that way our default matches the default core will return and we do not need to deal with that.

in fact, we had the default-passing in old cores, but got rid of that as it turned out to be tricky and error-prone in detail one cannot even think of atm :) tbh, i would prefer to not introduce a getConfig(key, default) again, at least not for a comparable side-quested thing

i also think, it just does not work. for unset keys, getConfig() does not return NULL or throws an error, but returns a default value, this is an empty string unless something else is defined in core

the try/catch is only to catch Integer-parsing exceptions

I renamed it again

src/main/res/values/strings.xml

…hat is muted

Co-authored-by: bjoern <r10s@b44t.com>

github-actions · 2024-12-04T12:32:36Z

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s

nice, with the option i think it is fine to get it in, even in 1.50.x

github-actions · 2024-12-04T13:25:01Z

To test the changes in this pull request, install this apk:
📦 app-preview.apk

adbenitez requested review from r10s and Hocuri November 29, 2024 19:16

r10s reviewed Dec 2, 2024

View reviewed changes

adbenitez force-pushed the adb/improve-notifications branch from 05a5e43 to 58523a2 Compare December 2, 2024 17:12

adbenitez changed the title ~~improve notifications handling~~ notify webxdc events, replies and reactions to own messages even if chat is muted Dec 2, 2024

adbenitez self-assigned this Dec 2, 2024

r10s mentioned this pull request Dec 2, 2024

do not notify if the webxdc is open #3460

Merged

r10s added notify wait-for-merge-window potentially dangerous or otherwise unfitting PR waiting for better merge timing labels Dec 3, 2024

r10s approved these changes Dec 3, 2024

View reviewed changes

adbenitez and others added 4 commits December 4, 2024 12:59

notify webxdc events, replies and reactions to own messages even if c…

e245e29

…hat is muted

add option to disable notifying "mentions" in muted chats

9eefcac

rename to ui.notify_mentions_if_muted and improve code

6a61898

Update src/main/res/values/strings.xml

af91cf7

Co-authored-by: bjoern <r10s@b44t.com>

adbenitez force-pushed the adb/improve-notifications branch from db7f641 to af91cf7 Compare December 4, 2024 11:59

rename config name and meaning

ab5a9c9

r10s approved these changes Dec 4, 2024

View reviewed changes

r10s removed the wait-for-merge-window potentially dangerous or otherwise unfitting PR waiting for better merge timing label Dec 4, 2024

adbenitez merged commit 75296e1 into main Dec 6, 2024
2 checks passed

adbenitez deleted the adb/improve-notifications branch December 6, 2024 14:33

This was referenced Dec 7, 2024

add "mention" notification switch deltachat/deltachat-ios#2429

Closed

add mentions toggle deltachat/deltachat-ios#2434

Merged

r10s mentioned this pull request Jan 8, 2025

notify about "mentions", add "mention" switch deltachat/deltachat-desktop#4461

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

notify webxdc events, replies and reactions to own messages even if chat is muted #3456

notify webxdc events, replies and reactions to own messages even if chat is muted #3456

adbenitez commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 30, 2024

r10s commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

r10s Dec 2, 2024

adbenitez Dec 2, 2024 •

edited

Loading

Hocuri Dec 2, 2024

adbenitez Dec 2, 2024

adbenitez Dec 2, 2024

adbenitez Dec 2, 2024

Hocuri Dec 2, 2024

adbenitez Dec 2, 2024

r10s Dec 2, 2024 •

edited

Loading

adbenitez Dec 2, 2024

r10s commented Dec 2, 2024 •

edited

Loading

adbenitez commented Dec 2, 2024

adbenitez commented Dec 2, 2024

adbenitez commented Dec 2, 2024

r10s commented Dec 2, 2024 •

edited

Loading

adbenitez commented Dec 2, 2024 •

edited

Loading

r10s commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024

r10s left a comment

r10s Dec 3, 2024

adbenitez Dec 4, 2024

adbenitez Dec 4, 2024

r10s Dec 4, 2024 •

edited

Loading

r10s Dec 4, 2024 •

edited

Loading

adbenitez Dec 4, 2024

github-actions bot commented Dec 4, 2024

r10s left a comment •

edited

Loading

github-actions bot commented Dec 4, 2024

notify webxdc events, replies and reactions to own messages even if chat is muted #3456

notify webxdc events, replies and reactions to own messages even if chat is muted #3456

Conversation

adbenitez commented Nov 29, 2024 • edited Loading

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 30, 2024

r10s commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

Choose a reason for hiding this comment

adbenitez Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

r10s Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

r10s commented Dec 2, 2024 • edited Loading

adbenitez commented Dec 2, 2024

adbenitez commented Dec 2, 2024

adbenitez commented Dec 2, 2024

r10s commented Dec 2, 2024 • edited Loading

adbenitez commented Dec 2, 2024 • edited Loading

r10s commented Dec 2, 2024 • edited Loading

github-actions bot commented Dec 2, 2024

r10s left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

r10s Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

r10s Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2024

r10s left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2024

adbenitez commented Nov 29, 2024 •

edited

Loading

adbenitez Dec 2, 2024 •

edited

Loading

r10s Dec 2, 2024 •

edited

Loading

r10s commented Dec 2, 2024 •

edited

Loading

r10s commented Dec 2, 2024 •

edited

Loading

adbenitez commented Dec 2, 2024 •

edited

Loading

r10s commented Dec 2, 2024 •

edited

Loading

r10s Dec 4, 2024 •

edited

Loading

r10s Dec 4, 2024 •

edited

Loading

r10s left a comment •

edited

Loading