fix: await the tasks after aborting them #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/no-try-many-times2
branch
2 times, most recently
from
9e7a43b to
fd84136
Compare
link2xt
changed the title
link2xt
changed the title
link2xt
force-pushed
the
link2xt/no-try-many-times2
branch
from
fd84136 to
07dee55
Compare
iequidoo
approved these changes
Jul 30, 2024
link2xt
force-pushed
the
link2xt/no-try-many-times2
branch
from
07dee55 to
edc0c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #5809
I tested that it fixes the problem without #5814, but let's keep both fixes to be sure.