Code

File deduplication#6332

Code

Merged

Hocuri merged 44 commits intomaindeltachat/deltachat-core-rust:mainfrom hoc/file-deduplicationdeltachat/deltachat-core-rust:hoc/file-deduplicationCopy head branch name to clipboardJan 21, 2025

+582-239

Commits

Commits on Jan 20, 2025

• File deduplication

  Hocuri

  committed
  908a187

  Copy full SHA for 908a187

• --wip-- [skip ci]

  Hocuri

  committed
  28a07e0

  Copy full SHA for 28a07e0

• Fix the tests (some of the fixes may need a new test)

  Hocuri

  committed
  7a43aa4

  Copy full SHA for 7a43aa4

• Fix some more tests, I'll need to remove some println statements

  Hocuri

  committed
  9dcaa41

  Copy full SHA for 9dcaa41

• Adapt more tests and fix most of them

  Hocuri

  committed
  260015d

  Copy full SHA for 260015d

• test: Assume that the avatar name also changes

  Hocuri

  committed
  a64c72c

  Copy full SHA for a64c72c

• Adapt summary.rs tests

  Hocuri

  committed
  e0fdcf4

  Copy full SHA for e0fdcf4

• Adapt some more tests, they all pass

  Hocuri

  committed
  4c47d4c

  Copy full SHA for 4c47d4c

• Adapt src/receive_imf/tests.rs, fails because there is no deduplication on reception

  Hocuri

  committed
  1698b6b

  Copy full SHA for 1698b6b

• Deduplicate on message reception, fix all tests

  Hocuri

  committed
  33f89f3

  Copy full SHA for 33f89f3

• Small tweaks, clippy

  Hocuri

  committed
  79b69ac

  Copy full SHA for 79b69ac

• Set deduplicated files as read-only on the file system

  Hocuri

  committed
  c22e8dc

  Copy full SHA for c22e8dc

• Set the file modification time so that it's not deleted during housekeeping

  Hocuri

  committed
  6906db7

  Copy full SHA for 6906db7

• Deduplicate the code writing a file

  Hocuri

  committed
  0beb1c9

  Copy full SHA for 0beb1c9

• Use only the first 32 characters of the hash

  Hocuri

  committed
  a5c51ae

  Copy full SHA for a5c51ae

• Keep the code repairing Param::Filename extensions for now

  Show description for c2cec63
  Hocuri

  committed
  c2cec63

  Copy full SHA for c2cec63

• Some renames, leave set_file_from_bytes() being pub for now

  Hocuri

  committed
  bb81e3b

  Copy full SHA for bb81e3b

• Create blob dir if it doesn't exist

  Hocuri

  committed
  d012bc2

  Copy full SHA for d012bc2

• Document and expose via the C ffi

  Hocuri

  committed
  c6e32aa

  Copy full SHA for c6e32aa

• Use the actual file's name if name is None

  Hocuri

  committed
  72fe759

  Copy full SHA for 72fe759

• Clippy

  Hocuri

  committed
  c5074ab

  Copy full SHA for c5074ab

• clippy: Make functions that are not async not be async

  Hocuri

  committed
  f05b057

  Copy full SHA for f05b057

• Fix mistake I made when rebasing

  Hocuri

  committed
  9935d1f

  Copy full SHA for 9935d1f

• Documentation

  Hocuri

  committed
  44bbfbe

  Copy full SHA for 44bbfbe

• create_and_deduplicate_from_bytes: check if the file content is still correct when deduplicating

  Hocuri

  committed
  469baf0

  Copy full SHA for 469baf0

• Documentation

  Hocuri

  committed
  f38c915

  Copy full SHA for f38c915

• clippy

  Hocuri

  committed
  3204282

  Copy full SHA for 3204282

• Fix unit tests on Windows

  Hocuri

  committed
  a1b44ab

  Copy full SHA for a1b44ab

• Fix python tests

  Hocuri

  committed
  30be873

  Copy full SHA for 30be873

• Update deltachat-ffi/src/lib.rs

  Show description for e281aea
  

  Hocuri

  and

  link2xt

  committed
  e281aea

  Copy full SHA for e281aea

• Update deltachat-ffi/src/lib.rs

  Show description for acad86d
  

  Hocuri

  and

  link2xt

  committed
  acad86d

  Copy full SHA for acad86d

• Update src/blob.rs

  Show description for a108e63
  

  Hocuri

  and

  link2xt

  committed
  a108e63

  Copy full SHA for a108e63

• Make create_and_deduplicate_from_bytes() a thin wrapper around create_and_deduplicate()

  Hocuri

  committed
  272b7e3

  Copy full SHA for 272b7e3

• Remove redundant & hard to understand comment

  Hocuri

  committed
  f6c019e

  Copy full SHA for f6c019e

• clippy

  Hocuri

  committed
  ac35c97

  Copy full SHA for ac35c97

• fix(housekeeping): Set files to be readonly before deleting

  Show description for 3fa0217
  Hocuri

  committed
  3fa0217

  Copy full SHA for 3fa0217

• Only set readonly=false on Windows because on Unix, it would make the file world-writeable

  Show description for f97882d
  Hocuri

  committed
  f97882d

  Copy full SHA for f97882d

• Septias' review

  Hocuri

  committed
  b49b181

  Copy full SHA for b49b181

• 2 small readability fixes

  Hocuri

  committed
  1761804

  Copy full SHA for 1761804

• more Septias review

  Hocuri

  committed
  7967437

  Copy full SHA for 7967437

• Copy files to the blobdir first if they are not already there

  Hocuri

  committed
  6f6825b

  Copy full SHA for 6f6825b

Commits on Jan 21, 2025

• Merge remote-tracking branch 'origin/main' into hoc/file-deduplication

  Hocuri

  committed
  4aba5a8

  Copy full SHA for 4aba5a8

• Don't set blob files as read-only

  Show description for 9bc4071
  Hocuri

  committed
  9bc4071

  Copy full SHA for 9bc4071

• Update src/blob.rs

  Show description for a7d138f
  

  Hocuri

  and

  link2xt

  authored
  a7d138f

  Copy full SHA for a7d138f