always expect bad c-strings #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function to_string() is removed; c-strings may always be badly formatted and this should never lead to a panic.
hpk42
approved these changes
Oct 5, 2019
There was a problem hiding this comment.
this was discussed also with @dignifiedquire who also agreed it's good to just use to_string_lossy and be done. C-strings come from mime-parsing and mime-generation and it makes sense to not crash on wrong utf8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always use to_string_lossy() for converting c-strings to String
the function to_string() is removed;
c-strings may always be badly formatted and this should never lead to a panic.
nb: also scanned over the remaining .to_string() member functions, seems as if .to_string_lossy() is already called where it is needed, eg. for Path or OsString objects.