Skip to content

Commit

Permalink
consolidate wording for "Message Info" (#3961)
Browse files Browse the repository at this point in the history
* consolidate wording for "Message Info"

gist is to use an easier, less cluttering language -
before, we had context menu items named 'Info', 'Message Details' or just 'i',
opening then 'Message Details'.

together with deltachat/deltachat-android#3137 ,
the menu entry will be named 'Info' everywhere and open a 'Message Info' dialog,
this has the following benefits:

- inner consistency to other Delta Chat apps
  all apps have recognizable 'Info' in their context menu,
  opening a 'Message Info' dialog

- inner consistency to other desktopn menu entries:
  'Message Details' is a little too much as the context 'Message' is already clear.
  (we also do not say 'Forward Message' or 'Reply to Message';
  as an exception, we regard only 'Delete Message').

- also, 'Info' is shorter and fits better to the otherwise short menu titles.

- outer consistency: 'Info' is very well known for that kind of, well, info

* add CHANGELOG entry
  • Loading branch information
r10s authored Jun 19, 2024
1 parent 81652ca commit 9b0c380
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Changed
- reword advanced setting "Disable Background Sync For All Accounts" -> "Only Synchronize the Currently Selected Account" #3960
- use 'Info' and 'Message Info' consistently #3961

### Fixed
- Fix crash on "Settings" click when not on main screen (e.g. no account selected): hide the "settings" button
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/components/attachment/mediaAttachment.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const contextMenuFactory = (
action: () => jumpToMessage(accountId, message.id),
},
{
label: tx('menu_message_details'),
label: tx('info'),
action: () => {
openDialog(MessageDetail, { id: msgId })
},
Expand Down
4 changes: 2 additions & 2 deletions src/renderer/components/dialogs/ChatAuditLogDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ function buildContextMenu(
navigator.clipboard.writeText(message.text || '')
},
},
// Message details
// Message Info
{
label: tx('menu_message_details'),
label: tx('info'),
action: openMessageInfo.bind(null, openDialog, message),
},
]
Expand Down
4 changes: 2 additions & 2 deletions src/renderer/components/message/Message.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,9 @@ function buildContextMenu(
BackendRemote.rpc.resendMessages(selectedAccountId(), [message.id])
},
},
// Message details
// Message Info
{
label: tx('menu_message_details'),
label: tx('info'),
action: openMessageInfo.bind(null, openDialog, message),
},
// Delete message
Expand Down

0 comments on commit 9b0c380

Please sign in to comment.