-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Paste image from clipboard" - Compatibility #2323
Comments
What format is the pasted image? |
That's why it's a preview built ;) I'm currently not running master, so not sure what's going on there exactly, but there will be some big changes in the next days/weeks that will affect stability. Probably switch to a stable version?
No, where it's not working. Can you figure out the format of the snipaste tool if it's not working? |
Because I urgently need this feature, I have been paying attention to the update status of the portable program during the recent period. As long as there is an update, I will download it for a trial. |
Hmm maybe we can make a more stable build for you with this feature.
Looking again at the exception, i had this too yesterday. I think it happens as soon as any error is getting thrown. Probably the stack parser is making problems @Simon-Laux
Thank you, but I rarely use windows. Can you turn on debugging and tell us more about the format of the non working paste? You can turn on debugging logs if you start DeltaChat from cmd/powershell like this: |
The test cannot continue. Because once I press Ctrl + V, there is a very high probability that the Delta Chat interface will become blank. |
Yes, i expect something similiar. Can you try out the windows preview build of #2336 ? I fixed some errors that you had, this should also help debugging this problem. In case you get any more blanks, please open an issue with the error, i will try to fix it :) Thanks for testing our unstable previews :) |
".\deltachat-desktop-2336.portable_2.exe" --log-debug --log-to-console |
Maybe it's not possible with the portable build. Maybe you can try |
".\deltachat-desktop-2336.portable_2.exe" -- --log-debug --log-to-console It may contain the information you need. The pasted image at this time looks like this: P.S.: The CPU usage of this program is abnormal. |
Somehow deltachat thinks it's a png, but should be a bmp i guess.
Quite chill for me, is this a regression in the recent time? |
Can you try the stable released 1.20.3 ? https://download.delta.chat/desktop/v1.20.3/DeltaChat%201.20.3.exe |
|
Probably this is the problem: |
It is the next day, and the computer has restarted. |
That's goodish. Please report any problems you have with that version, I don't know of anybody else using deltachat-desktop on win7 :) |
The reason why I don't use the desktop version on Windows 10: #2263 |
when we removed all dependencies to electron from the backend code and completed making all desktop used apis available in https://github.com/deltachat/dc_cmd_api and doing the other steps to make it ready. |
Probably offtopic talk about tauri, but could we get a small example running where we have dc_cmd_api + tauri running with a small react example using esbuild...? I think having this stack ready could be quite nice for further experiments. |
Am I understanding correctly:
This should not hold up a release IMO. |
In short: this is indeed a feature that can greatly enhance the user experience. However, on Windows, this feature seems to be picky about the image format in the clipboard. It accepts PNG / JPEG / GIF / WEBP format (tested). However, a considerable part of the images copied to the clipboard by the program are in BMP format. If you try to paste such an image into Delta Chat, an exception will occur. |
Don't worry, no release will be blocked because of this issue ;) This pr is currently blocking the release, but it's almost done; #2342 |
As a user, feedback is my right, you are welcome. |
No problem, it had just been some time since the work had been done... I run into this all the time, and then I thought maybe this thread is what halted it... Now I realize it is actually #2342 |
@YamatoRyou And very appreciated :)
#2342 is quite finished, you can use the preview builds to try it out. https://download.delta.chat/desktop/preview/deltachat-desktop-2342.AppImage |
After testing, it still doesn't work. Version being tested:
|
This is a change of the clipboard, to demonstrate Chrome and Snipaste respectively: |
It wasn't about this issue :) |
Found 3 new issues.
In addition, I also found that no matter how many accounts are in the account list, the user name is always displayed as "Me". I think this is not very good. |
I tested the paste feature from the repo and it works perfectly on Linux. Can't wait to get it via a Flathub update :) I'm hoping the fine tuning for other systems can come later. I might be willing to help in that case. I do see there are multiple ways to determine the MIME type with JavaScript (ES5) on the client side: https://stackoverflow.com/a/29672957 .. but it's already working in Linux and certain Windows configurations, just needs a little more checking to determine the MIME type to cover all the bases in Windows specifically |
Tested the paste in the preview version and it works perfectly :) :) :) Though FYI, to get the preview version running I had to create a directory after seeing this error:
Once I created the directory It opened fine... Note that other than the preview version tonight, I'm using Flatpak for the mainline install.. So I assume it was expecting a directory to already be there from a non-Flatpak install |
#2319
I tested the following software's clipboard function and found the problem when it was pasted into Delta Chat.
Chrome 86: The image cannot be displayed normally when pasted into Delta Chat.
Internet Explorer 11: The image cannot be displayed normally when pasted into Delta Chat.
Firefox 79: The image cannot be displayed normally when pasted into Delta Chat.
Delta chat: Paste the image normally (click on the image from chat and copy from the right-click menu).
The result is as shown below:
I have an additional screenshot tool, guess this may be caused by the image format in the clipboard. If you don't select "ScreenShot", this problem will not occur.
The text was updated successfully, but these errors were encountered: