Fix server flags configuration #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2019 04:30
deltachat-node do not use serverFlags key and store "undefined" in the database when "server_flags" are not passed
It is converted to "null" string and stored in the database by the server core. Returning 0 is good enough to trigger deltachat-rust-core guessing logic.
|
I have tested that at least on the initial configuration, server flags are set successfully in the database: They are not |
It receives a dictionary of credentials, which contain mail_security and send_security, not mailSecurity and sendSecurity
|
In fact the intial configuration is now set correct, but updating the configuration still doesn't work. Should be fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #1025